Skip to content

Fix nfts thumbnail processing#1609

Open
stefangutica wants to merge 1 commit into
developmentfrom
nfts-thumbnail-process
Open

Fix nfts thumbnail processing#1609
stefangutica wants to merge 1 commit into
developmentfrom
nfts-thumbnail-process

Conversation

@stefangutica

Copy link
Copy Markdown
Collaborator

Reasoning

  • The current FFmpeg configuration fails for standard "limited range" video streams, causing an "Invalid argument" error in the MJPEG encoder.
  • The encoder requires explicit pixel format and strictness settings to accept standard H.264/YUV420p video inputs.

Proposed Changes

  • Added .videoFilters('format=yuv420p') to ensure consistent color space compatibility.
  • Added .outputOptions(['-strict', 'unofficial']) to allow processing of standard video color ranges.

How to test

  • Run the thumbnail generation service on an NFT asset that previously triggered the "Non full-range YUV" error.
  • Verify that the thumbnail is correctly generated and saved to the output path without FFmpeg errors.

@github-actions

Copy link
Copy Markdown

k6 load testing comparison.
Base Commit Hash: 64adf08
Target Commit Hash: 6720ba8

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex46.84202.0659.7862.2837.79446.0851.6455.23-19.34% ✅+120.77% 🔴-13.62% ✅-11.33% ✅
Accounts49.04695.1559.9962.4239.76686.1152.2955.57-18.93% ✅-1.30% ✅-12.83% ✅-10.97% ✅
Nodes47.00253.3559.9762.1557.6814943.4655.4560.14+22.74% 🔴+5798.28% 🔴-7.53% ✅-3.24% ✅
Transactions59.331998.8660.9363.7865.3115245.6154.9057.31+10.08% 🔴+662.72% 🔴-9.89% ✅-10.14% ✅
Blocks53.20634.4060.6263.5344.263660.5353.8556.43-16.81% ✅+477.01% 🔴-11.17% ✅-11.19% ✅
Pool47.09273.2959.8762.2737.55203.1651.2355.24-20.25% ✅-25.66% ✅-14.43% ✅-11.30% ✅
Tokens47.36665.3560.0162.1837.60305.7851.4155.25-20.61% ✅-54.04% ✅-14.33% ✅-11.14% ✅
Test Run Duration60003.1660002.35

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant